Improvements #102
Improvements #102
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project infrastructure by dropping Node.js 18 support, migrating from CommonJS to ES modules, updating configuration files, and adding webpack for production builds. The changes improve code organization by moving generated files from the root to a dist/ directory.
Key changes:
- Migration from CommonJS (
module.exports/require) to ES modules (export/import) - Introduction of webpack for bundling with separate dev and production configurations
- Code style updates for consistency (single quotes, ES6 shorthand)
Reviewed Changes
Copilot reviewed 18 out of 35 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| wf.js | Removed ontology file from root (moved to generated dist/) |
| ui.js | Removed ontology file from root (moved to generated dist/) |
| trackerSettingsForm.js | Removed form file from root (moved to generated dist/) |
| webpack.dev.config.js | Converted to ES modules and updated dev server config |
| webpack.config.js | Added new production webpack configuration |
| src/newTracker.js | Removed unused variable declaration |
| src/newIssue.js | Updated string quotes for consistency |
| src/issuePane.js | Updated import paths and removed incomplete statement |
| src/issue.js | Removed unnecessary eslint-disable comments |
| src/csvButton.js | Code style improvements and formatting fixes |
| package.json | Updated main entry point, added build scripts, and updated dependencies |
| eslint.config.mjs | Migrated to neostandard config |
| dev/index.js | Converted to ES modules and updated imports |
| dev/context.js | Converted to ES modules and removed unused import |
| babel.config.js | Converted to ES modules and updated preset configuration |
| Makefile | Updated paths to use src/ and dist/ directories |
| test/big-tracker.ttl | Updated file references and comments |
| .github/workflows/ci.yml | Removed Node.js 18 from test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 35 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Drop node 18
better configs
better structure
added webpack for build - use solid-ui, solid-logic and rdflib as externals -> not bundled in release. Added them as peerDependencies because they are only used in local development. In production they should be provided by mashlib.